test visualization, fix second test ski area

dhimmel · Oct 28, 2024 · 4de1dbd · 4de1dbd
1 parent c125fb9
commit 4de1dbd
Show file tree

Hide file tree

Showing 8 changed files with 5,074 additions and 2,137 deletions.
diff --git a/ski_bearings/analyze.py b/ski_bearings/analyze.py
@@ -216,7 +216,7 @@ def bearing_dists_by_country() -> pl.DataFrame:
     )
 
 
-def ski_rose_the_world() -> pl.DataFrame:
+def ski_rose_the_world(min_combined_vertical: int = 10_000) -> pl.DataFrame:
     path = get_data_directory().joinpath("ski-roses.pdf")
     pdf_pages = PdfPages(
         filename=path,
@@ -232,8 +232,15 @@ def ski_rose_the_world() -> pl.DataFrame:
     }
     figures = []
     for grouping_col, groups_pl in grouping_col_to_stats.items():
-        logging.info(f"Plotting ski rose the world by {grouping_col}")
-        groups_pl = groups_pl.filter(pl.col("combined_vertical") > 10_000)
+        logging.info(f"Plotting ski roses by {grouping_col}")
+        groups_pl = groups_pl.filter(
+            pl.col("combined_vertical") >= min_combined_vertical
+        )
+        if groups_pl.is_empty():
+            logging.info(
+                f"Skipping {grouping_col} plot which returns no groups with combined_vertical >= {min_combined_vertical:,}m."
+            )
+            continue
         fig = subplot_orientations(
             groups_pl=groups_pl,
             grouping_col=grouping_col,

diff --git a/ski_bearings/openskimap_utils.py b/ski_bearings/openskimap_utils.py
@@ -198,7 +198,7 @@ def _clean_coordinates(
 
 test_ski_area_ids = [
     "8896cde00150e73de1f1237320c88767c91ce099",  # Whaleback Mountain
-    "0dd6fca32f6c8a9cc7f681a9267f86b58415ea60",  # Storrs Hill Ski Area
+    "dc24f332f3117625dc09479b5d10cbb31a592be4",  # Storrs Hill Ski Area
 ]
 
 

diff --git a/ski_bearings/plot.py b/ski_bearings/plot.py
@@ -226,7 +226,11 @@ def subplot_orientations(
     n_rows = math.ceil(n_subplots / n_cols)
     figsize = (n_cols * SUBPLOT_FIGSIZE, n_rows * SUBPLOT_FIGSIZE)
     fig, axes = plt.subplots(
-        n_rows, n_cols, figsize=figsize, subplot_kw={"projection": "polar"}
+        nrows=n_rows,
+        ncols=n_cols,
+        squeeze=False,
+        figsize=figsize,
+        subplot_kw={"projection": "polar"},
     )
     dists_pl = (
         groups_pl.select(grouping_col, "bearings")

diff --git a/ski_bearings/tests/data/.gitignore b/ski_bearings/tests/data/.gitignore
@@ -1 +1,2 @@
-*.parquet
+*.parquet
+*.pdf