feat: toolbar UI update with hoverable menu (#1478) #1509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HendrikThePendric
force-pushed
the
feat/toolbar-ui-update-with-hoverable-menu-bar
branch
from
244145d
to
24d21c1
Compare
BREAKING CHANGE The `FileMenu` is now using the new `HoverMenuBar` components which makes this version of the `FileMenu` incompatible with the previous version. Apps will be need to update their toolbar and file menu before using this version of analytics.
HendrikThePendric
force-pushed
the
feat/toolbar-ui-update-with-hoverable-menu-bar
branch
from
24d21c1
to
129ad4a
Compare
janhenrikoverland
approved these changes
Jun 20, 2023
HendrikThePendric
deleted the
feat/toolbar-ui-update-with-hoverable-menu-bar
branch
dhis2-bot
added a commit
that referenced
this pull request
Jun 20, 2023
# [26.0.0](v25.2.3...v26.0.0) (2023-06-20) ### Features * toolbar UI update with hoverable menu ([#1478](#1478)) ([#1509](#1509)) ([0a51153](0a51153)) ### BREAKING CHANGES * The `FileMenu` is now using the new `HoverMenuBar` components which makes this version of the `FileMenu` incompatible with the previous version. Apps will be need to update their toolbar and file menu before using this version of analytics.
|
🎉 This PR is included in version 26.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements DHIS2-15167
Relates to dhis2/line-listing-app#368 & dhis2/data-visualizer-app#2358
Key features
ToolbarandToolbarSidebarcomponents to build the toolbar layoutHoverMenubarand related components to build hoverable menu within the toolbarUpdateButtonandInterpretationsAndDetailsTogglerto be placed in the toolbarFileMenuto be a hoverable dropdown menu, leveraging the new hover-menu-bar components.initiallyActiveTabKeytoVisualizationOptionscomponent so it can be opened at a specified tab.BREAKING CHANGE
The updated
FileMenuis not compatible with the previous version. Apps will be required to update their toolbar before using this version of analytics.TODO
Screenshots
Not the most glamorous screenshot, but it works.