Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement organisation filter #748

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

kabaros
Copy link
Collaborator

@kabaros kabaros commented Jan 21, 2025

implements HUB-161

organisations-list-with-show-more.webm

@kabaros
Copy link
Collaborator Author

kabaros commented Jan 21, 2025

ps: PR against changelog branch for now

@kabaros kabaros requested a review from a team January 21, 2025 20:22
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 52.63158% with 9 lines in your changes missing coverage. Please review.

Project coverage is 67.80%. Comparing base (53b45ca) to head (916b25e).

Files with missing lines Patch % Lines
client/src/pages/Apps/Filters/Filters.js 50.00% 9 Missing ⚠️
Additional details and impacted files
@@                      Coverage Diff                       @@
##           feat/changelog-improvement     #748      +/-   ##
==============================================================
- Coverage                       68.12%   67.80%   -0.32%     
==============================================================
  Files                              29       29              
  Lines                             571      584      +13     
  Branches                          132      138       +6     
==============================================================
+ Hits                              389      396       +7     
- Misses                            171      177       +6     
  Partials                           11       11              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -69,6 +69,24 @@ module.exports = [
return orgs
},
},
{
method: 'GET',
path: '/v2/organisations-with-apps',
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure about the route name - the API is not RESTful anyhow, so went for simplicity

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would expect this to be under /organisations. And maybe a resource under that?

@kabaros kabaros force-pushed the feat/changelog-improvement branch 6 times, most recently from 0a23e3d to 8144651 Compare January 22, 2025 17:04
@kabaros kabaros force-pushed the feat/changelog-improvement branch 6 times, most recently from ed516a0 to 60cdfae Compare January 23, 2025 11:17
Base automatically changed from feat/changelog-improvement to next February 5, 2025 16:17
Base automatically changed from next to master February 13, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants