feat: allow manually adding changes summary to a version of an app #752
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #752 +/- ##
=========================================
Coverage ? 65.83%
=========================================
Files ? 29
Lines ? 559
Branches ? 131
=========================================
Hits ? 368
Misses ? 178
Partials ? 13 ☔ View full report in Codecov by Sentry. |
| @@ -32,21 +32,26 @@ const InitializeAuth = ({ children }) => { | |||
| }, [getAccessTokenSilently]) | |||
|
|
|||
| useEffect(() => { | |||
| if (!isLoading && isAuthenticated && user) { | |||
| const getUserInfo = async () => { | |||
There was a problem hiding this comment.
I can't remember anymore if this is the right way of doing a side effect in Redux without something like redux-thunk - but I don't see redux-thunk installed and this seems to work
| version: values, | ||
| }) | ||
| let message = `Successfully created app version ${values.version}` | ||
| if (editMode) { |
There was a problem hiding this comment.
is it worth it keeping the same component for edit and add? I wasn't sure (but I should at least update the file name if this doesn't look too messy for people)
| @@ -91,6 +91,8 @@ module.exports = { | |||
| throw Boom.notFound('No apps found') | |||
| } | |||
|
|
|||
| return v1FormattedArray[0] | |||
| const result = v1FormattedArray[0] | |||
| result.userCanEditApp = isDeveloper | |||
There was a problem hiding this comment.
this is the easiest way I found to be able to decide if a user should be able to edit, without making an extra call
kabaros
force-pushed
the
manual-changelog
branch
from
237e1ee to
71cf1ea
Compare
This adds the ability to manually edit/add change summary, to show in addition to the change log summary for the CHANGELOG.md.
implements https://dhis2.atlassian.net/browse/HUB-167
manual-changes-create.webm
manual-changes-edit.webm