Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [DHIS2-18329] Add org unit selector in schedule event form #3925

Merged
merged 13 commits into from
Jan 31, 2025
Merged

feat: [DHIS2-18329] Add org unit selector in schedule event form #3925

merged 13 commits into from
Jan 31, 2025

Conversation

henrikmv
Copy link
Contributor

@henrikmv henrikmv commented Jan 2, 2025 •
edited
Loading

DHIS2-18329:

  • Implemented org. unit selector in Schedule tab
  • Modified the Infobox

@henrikmv henrikmv marked this pull request as ready for review January 2, 2025 13:14
@henrikmv henrikmv requested a review from a team as a code owner January 2, 2025 13:14
simonadomnisoru
simonadomnisoru reviewed Jan 8, 2025
View reviewed changes
Copy link
Contributor

@simonadomnisoru simonadomnisoru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @henrikmv,
Great start for this feature👏 ! I like that you used the existing folder structure from the existing DataEntries.
In addition to the code comments, I was wondering how this feature will work once DHIS2-15685 is merged. Can the user reschedule an event without having an org unit selected in ScopeSelector?
Thank you!

...e_modules/capture-core/components/WidgetEventSchedule/ScheduleDate/ScheduleDate.component.js Outdated Show resolved Hide resolved
src/core_modules/capture-core/components/WidgetEventSchedule/WidgetEventSchedule.container.js Outdated Show resolved Hide resolved
src/core_modules/capture-core/components/WidgetEventSchedule/WidgetEventSchedule.component.js Outdated Show resolved Hide resolved
src/core_modules/capture-core/components/WidgetEventSchedule/widgetEventSchedule.types.js Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025 •
edited
Loading

🚀 Deployed on https://deploy-preview-3925.capture.netlify.dhis2.org

@henrikmv henrikmv added e2e record Apply this label to a pull request to trigger recording of E2E tests on Cypress Cloud and removed testing e2e record Apply this label to a pull request to trigger recording of E2E tests on Cypress Cloud labels Jan 9, 2025
simonadomnisoru
simonadomnisoru approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@simonadomnisoru simonadomnisoru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@henrikmv henrikmv added testing and removed testing labels Jan 15, 2025
@henrikmv henrikmv removed the e2e record Apply this label to a pull request to trigger recording of E2E tests on Cypress Cloud label Jan 16, 2025
@henrikmv henrikmv marked this pull request as draft January 16, 2025 14:39
@henrikmv henrikmv added testing and removed testing labels Jan 17, 2025
@henrikmv henrikmv marked this pull request as ready for review January 17, 2025 12:03
@henrikmv henrikmv marked this pull request as draft January 17, 2025 12:03
@henrikmv henrikmv marked this pull request as ready for review January 17, 2025 12:06
@henrikmv henrikmv added testing and removed testing labels Jan 24, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

geethaalwan
geethaalwan approved these changes Jan 28, 2025
View reviewed changes
Copy link

@geethaalwan geethaalwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested successfully on 2.42,2.41.4,2.40.7,2.39.9 versions

@henrikmv henrikmv merged commit 4013d93 into master Jan 31, 2025
42 checks passed
@henrikmv henrikmv deleted the hv/feat/DHIS2-18329_ShowOrgUnitSelectorInScheduleEventForm branch January 31, 2025 09:31
dhis2-bot added a commit that referenced this pull request Jan 31, 2025
@dhis2-bot
chore(release): cut 101.24.0 [skip release]
402f2ad 
# [101.24.0](v101.23.2...v101.24.0) (2025-01-31)

### Features

* [DHIS2-18329] Add org unit selector in schedule event form ([#3925](#3925)) ([4013d93](4013d93))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 101.24.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonadomnisoru simonadomnisoru simonadomnisoru approved these changes

@geethaalwan geethaalwan geethaalwan approved these changes

Assignees
No one assigned
Labels
released testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@henrikmv @dhis2-bot @simonadomnisoru @geethaalwan