Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [DHIS2-8087] Add empty launch page #3940

Merged
merged 4 commits into from
Feb 5, 2025
Merged

feat: [DHIS2-8087] Add empty launch page #3940

merged 4 commits into from
Feb 5, 2025

Conversation

eirikhaugstulen
Copy link
Contributor

Summary:

  • Add an empty launch page

@eirikhaugstulen eirikhaugstulen requested a review from a team as a code owner January 15, 2025 14:51
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 15, 2025 •
edited
Loading

🚀 Deployed on https://deploy-preview-3940.capture.netlify.dhis2.org

@cooper-joe cooper-joe self-requested a review January 16, 2025 07:46
simonadomnisoru
simonadomnisoru reviewed Jan 16, 2025
View reviewed changes
Copy link
Contributor

@simonadomnisoru simonadomnisoru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @eirikhaugstulen, to better align it with the design in the Jira ticket, I added a few comments with some minor CSS tweaks.

...re_modules/capture-core/components/Pages/MainPage/NoSelectionsInfoBox/NoSelectionsInfoBox.js Outdated Show resolved Hide resolved
...re_modules/capture-core/components/Pages/MainPage/NoSelectionsInfoBox/NoSelectionsInfoBox.js Outdated Show resolved Hide resolved
...re_modules/capture-core/components/Pages/MainPage/NoSelectionsInfoBox/NoSelectionsInfoBox.js Show resolved Hide resolved
@eirikhaugstulen
Copy link
Contributor Author

Hey @simonadomnisoru - sorry this PR was meant to be in draft mode 😅 I totally agree with you that the design differs a bit, the idea was that we would bridge the gap a bit between this and the other feedback box (Therefore a similar gap, marginTop and so on). However, I thought it felt a bit wrong, so wanted Joe and Karoline to have a look. I'll update once they've looked through it 👍

@eirikhaugstulen
Merge remote-tracking branch 'origin/master' into eh/feat/DHIS2-8087-…
da33bb4 
…first-launch-state

# Conflicts:
#	i18n/en.pot
@eirikhaugstulen
Copy link
Contributor Author

Rewritten with updated styling @simonadomnisoru!

@eirikhaugstulen
Merge remote-tracking branch 'origin/master' into eh/feat/DHIS2-8087-…
9a8ae14 
…first-launch-state

# Conflicts:
#	i18n/en.pot
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 5, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@eirikhaugstulen eirikhaugstulen merged commit 66d949b into master Feb 5, 2025
42 checks passed
@eirikhaugstulen eirikhaugstulen deleted the eh/feat/DHIS2-8087-first-launch-state branch February 5, 2025 09:48
dhis2-bot added a commit that referenced this pull request Feb 5, 2025
@dhis2-bot
chore(release): cut 101.25.0 [skip release]
2626e7e 
# [101.25.0](v101.24.3...v101.25.0) (2025-02-05)

### Features

* [DHIS2-8087] Add empty launch page ([#3940](#3940)) ([66d949b](66d949b))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 101.25.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonadomnisoru simonadomnisoru simonadomnisoru approved these changes

@cooper-joe cooper-joe Awaiting requested review from cooper-joe

Assignees
No one assigned
Labels
released testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eirikhaugstulen @dhis2-bot @simonadomnisoru