feat: create embedded superset dashboard #3185
Conversation
|
🚀 Deployed on https://pr-3185.dashboard.netlify.dhis2.org |
HendrikThePendric
force-pushed
the
feat/create-embedded-superset-dashboard
branch
from
254d892 to
b99c2af
Compare
HendrikThePendric
force-pushed
the
feat/embedded-superset-dashboards-DHIS2-17891
branch
from
dd26c38 to
7a8f4cc
Compare
| }), | ||
| } | ||
|
|
||
| export const CreateSupersetEmbeddedDashboard = ({ |
There was a problem hiding this comment.
A more intuitive name imho would be something like ConfigureEmbeddedDashboardModal. (point being that this component is a modal). Or, ConfigureSupersetDashboardModal
I'll use this same comment to mention that the name of the folder doesn't really represent the breadth of it contents. Could it be named createDashboard (camelCase)? Very open to discussion.
| const FIELD_CHANGE = 'FIELD_CHANGE' | ||
| const SUPERSET_FIELD_BLUR = 'SUPERSET_FIELD_BLUR' | ||
| const UUID_PATTERN = | ||
| /^[0-9a-f]{8}-[0-9a-f]{4}-[1-5][0-9a-f]{3}-[89ab][0-9a-f]{3}-[0-9a-f]{12}$/i |
There was a problem hiding this comment.
There's not some tiny 3rd party library that could validate the uuid instead? If we intend to use our own like this, then there should be unit tests for it.
| <fieldset | ||
| ref={autoFocus} | ||
| className={styles.dashboardTypeRadioGroup} | ||
| tabIndex={0} |
There was a problem hiding this comment.
This is triggering a SonarQube failure.
|
This PR add the create flow:
Screen.Recording.2025-01-16.at.17.15.00.mov