Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support new dashboard plugin architecture #3082

Open
wants to merge 30 commits into
base: master
Choose a base branch
from

Conversation

edoardo
Copy link
Member

@edoardo edoardo commented Jun 4, 2024

Part of the fix for DHIS2-17268

Requires dhis2/analytics#1672


Key features

  1. use shared dashboard plugin wrapper

Description

Generic components for plugins are available in app-platform and app-runtime.
Analytics apps are currently having the same components replicated in each repo, a shared dashboard plugin wrapper has been added in analytics.


Known issues

  • an infinite loop happened and this seems to solve it, I'm not sure why and if this is a proper solution.

Screenshots

@dhis2-bot
Copy link
Contributor

dhis2-bot commented Jun 4, 2024

🚀 Deployed on https://pr-3082.data-visualizer.netlify.dhis2.org

@dhis2-bot dhis2-bot temporarily deployed to netlify June 4, 2024 13:52 Inactive
@edoardo edoardo changed the title Refactor/use platform plugin components refactor: use shared dashboard plugin wrapper Jun 4, 2024
@edoardo edoardo requested a review from KaiVandivier June 5, 2024 13:05
@dhis2-bot dhis2-bot temporarily deployed to netlify June 6, 2024 13:09 Inactive
@jenniferarnesen jenniferarnesen changed the base branch from dev to master June 21, 2024 09:48
@edoardo edoardo force-pushed the refactor/use-platform-plugin-components branch 2 times, most recently from ac182a8 to 4b736b2 Compare July 1, 2024 14:05
@dhis2-bot dhis2-bot temporarily deployed to netlify July 1, 2024 14:09 Inactive
@edoardo edoardo marked this pull request as ready for review July 3, 2024 09:57
@dhis2-bot dhis2-bot temporarily deployed to netlify July 3, 2024 09:58 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify August 1, 2024 13:46 Inactive
@edoardo edoardo force-pushed the refactor/use-platform-plugin-components branch from 6822d49 to 86d232d Compare August 2, 2024 13:31
@dhis2-bot dhis2-bot temporarily deployed to netlify August 2, 2024 13:34 Inactive
@edoardo edoardo force-pushed the refactor/use-platform-plugin-components branch from 86d232d to 39740ef Compare August 5, 2024 09:05
@dhis2-bot dhis2-bot temporarily deployed to netlify August 5, 2024 09:08 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify August 15, 2024 14:13 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify August 16, 2024 08:25 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify August 19, 2024 09:30 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify September 21, 2024 14:16 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify November 11, 2024 11:51 Inactive
@edoardo edoardo changed the title refactor: use shared dashboard plugin wrapper feat: support new dashboard plugin architecture Nov 11, 2024
@dhis2-bot dhis2-bot temporarily deployed to netlify November 11, 2024 15:12 Inactive
src/PluginWrapper.js Outdated Show resolved Hide resolved
@edoardo edoardo added the e2e record Apply this label to a pull request to trigger recording of E2E tests on Cypress Cloud label Nov 12, 2024
Copy link

cypress bot commented Nov 12, 2024

Data Visualizer App    Run #2962

Run Properties:  status check passed Passed #2962  •  git commit b3177adb87 ℹ️: Merge 5a345d10ca88a04df4c898bea2e643b8ac5ad7ab into ccc8ffe42fd69356e61acdf5861b...
Project Data Visualizer App
Branch Review refactor/use-platform-plugin-components
Run status status check passed Passed #2962
Run duration 10m 47s
Commit git commit b3177adb87 ℹ️: Merge 5a345d10ca88a04df4c898bea2e643b8ac5ad7ab into ccc8ffe42fd69356e61acdf5861b...
Committer Edoardo Sabadelli
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 737
View all changes introduced in this branch ↗︎

@dhis2-bot dhis2-bot temporarily deployed to netlify November 15, 2024 13:47 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e record Apply this label to a pull request to trigger recording of E2E tests on Cypress Cloud
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants