fix: infinite spinner when opening the interpretations modal while viewing a visualization #3283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-3283.data-visualizer.netlify.dhis2.org |
HendrikThePendric
approved these changes
Nov 7, 2024
src/components/VisualizationPlugin/VisualizationPluginWrapper.js
Outdated
Show resolved
Hide resolved
|
So essentially this PR fixes a bug in which I introduced when working on DHIS2-16793, and @jenniferarnesen asked me to double check that the current PR did not cause any problems with the original bugfix. I can hereby confirm it doesn't, see below: 
|
HendrikThePendric
approved these changes
Nov 7, 2024
dhis2-bot
added a commit
that referenced
this pull request
Nov 7, 2024
## [100.8.4](v100.8.3...v100.8.4) (2024-11-07) ### Bug Fixes * infinite spinner when opening the interpretations modal while viewing a visualization ([#3283](#3283)) ([403adbc](403adbc))
|
🎉 This PR is included in version 100.8.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DHIS2-18369
The InterpretationsModal callback onResponsesReceived was not being called after a recent fix introduced its own onResponsesReceived callback
TODO