fix: handle single value vis-type as highcharts chart instance #3289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-3289.data-visualizer.netlify.dhis2.org |
5 tasks
HendrikThePendric
added
the
e2e record
Data Visualizer App
|
||||||||||||||||||||||||||||
| Project |
Data Visualizer App
|
| Branch Review |
feat/use-analytics-version-with-single-value-as-highcharts-chart
|
| Run status |
|
| Run duration | 09m 27s |
| Commit |
|
| Committer | Hendrik de Graaf |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
734
|
| View all changes introduced in this branch ↗︎ | |
HendrikThePendric
removed
the
e2e record
edoardo
approved these changes
Nov 13, 2024
HendrikThePendric
deleted the
feat/use-analytics-version-with-single-value-as-highcharts-chart
branch
dhis2-bot
added a commit
that referenced
this pull request
Nov 13, 2024
## [100.8.5](v100.8.4...v100.8.5) (2024-11-13) ### Bug Fixes * handle single value vis-type as highcharts chart instance ([#3289](#3289)) ([83d0e6c](83d0e6c))
|
🎉 This PR is included in version 100.8.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No issue number available
Note for efficient reviewing
This code includes quite a few changes. However, the vast majority of changes were cherry picked from branch #3135, which had already been reviewed. The only file I edited manually was
src/components/VisualizationPlugin/ChartPlugin.js.Key features
Highcharts.Chartinstance, which it is since@dhis2/analyticsversion26.9.0Chart.exportChartLocal(IN THE FUTURE, NOT NOW)TODO