Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/app competition winners #124

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Refactor/app competition winners #124

wants to merge 7 commits into from
+327 −0

Conversation

gassims
Copy link
Contributor

@gassims gassims commented Aug 5, 2023 •
edited
Loading

  • removed the tabs navigation
  • updated the main component AppWinners.js to display the winners in the same page
  • made some styling changes
  • added info and content to the years 2023, 2022, and 2021

@gassims
Copy link
Contributor Author

gassims commented Aug 5, 2023 •
edited
Loading

Thank you @Topener !

Please see my new commit. Comments for updates are welcome. Some of the thoughts that I have:

  • maybe we no longer need to have that large layout for app name and description (any other suggestion?)
  • I need to look for the info for the 2020 competition
  • Android apps don't have links to app hub, should we link to Google Play store?
  • Some of the web apps aren't available in the app hub yet so the download button is blank

@gassims gassims mentioned this pull request Aug 5, 2023
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gassims