Use GH API to push commits in gihtub actions #3887
Open
+52
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresmr
reviewed
Nov 18, 2024
| # Commit and push | ||
| git commit -am "Update release notes" | ||
| git push | ||
| uses: flex-development/[email protected] |
There was a problem hiding this comment.
It creates the commit directly in github, there is no need to push (or it is implicit). The commit does not exist in the local repository. This is why we need to push the changes in the following step.
|
andresmr
approved these changes
Nov 19, 2024
Balcan
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR uses the DHIS2-bot to create the commit via GH API. In this way, Github automatically signed the commits.
If makes use of a plugin called gh-commit, which wraps the communication with the GH API via GraphQL API.
There is a limitation with protected branches: it seems that is not possible to push to protected branches via GraphQL (or GH API) even if the user is included in the Bypass list. As a workaround, the action creates an auxiliary branch to create the commit via API (so the commit is signed) and then it creates the
release/...branch from this auxiliary branch. And deletes the auxiliary branch. This workaround could be avoided if we manage to push commits to protected branches via GH API.ANDROAPP-6643
Covered unit test cases
Manually tested by triggering GH actions.
Checklist