fix: Org Unit split being assigned to incorrect users [DHIS2-18423]

[david-mackessy]

Issue

Org Unit split feature is assigning the split org units to incorrect users (sometimes all the users in the DB in certain circumstances)

Cause

After creating the UserQueryParams with the source OrganisationUnit, that OrganisationUnit was being overridden to use the User's OrganisationUnits carrying out the split.

In cases where the User either had no organisationUnits, dataViewOrganisationUnits, or teiSearchOrganisationUnits, then all the Users in the DB would be returned from the query, resulting in all Users getting the split OrganisationUnits.

Fix avoids using:

• UserService#handleUserQueryParams which was overriding the source OrganisationUnit already set
• UserStore#getUsers which tries to generate a handcrafted SQL query taking into consideration a multitude of options & checks using UserQueryParams (this looks too complex and tries to accommodate too many things). This resulted in returning all Users in the DB

Fix

Use a dedicated query to fetch the Users to be actioned.
Fewer select queries are generated as a result of the fix, and is not proportionate to the number of users found (old query was triggering 1 extra query per user found - manual testing).
Warning added to UserQueryParams property.

Testing

Automated

2 integration tests added

• 1 for Org Unit split service: checking that the correct users get assigned the split org units
• 1 for the store: checking the generated select query count & retrieved users

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[larshelge]

Perhaps not use "Method that" in method Javadoc, as it is implicit.