Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: reduce code complexity #144

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor: reduce code complexity #144

wants to merge 1 commit into from

Conversation

Balcan
Copy link
Contributor

@Balcan Balcan commented Oct 30, 2024

When the option list is too large the getOptionName method takes a lot of time in android. Using find extension function will reduce the number of loops to handle the list.

vgarciabnz
vgarciabnz requested changes Oct 31, 2024
View reviewed changes
Copy link
Member

@vgarciabnz vgarciabnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update version number before merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vgarciabnz vgarciabnz vgarciabnz requested changes

@andresmr andresmr andresmr approved these changes

@jbee jbee jbee approved these changes

@enricocolasante enricocolasante Awaiting requested review from enricocolasante

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Balcan @jbee @andresmr @vgarciabnz