Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible for the user to "retry" when a chunk fails to load. This should hopefully be a pretty rare occurrence so I'm not sure if this is actually needed, but I wanted to investigate the possibility of doing this.
The implementation seems a bit "hacky", since we force
react-router
to remount by recreating the router. But from my experimentation and research, there doesn't seem to be a way to "reload" / retry thelazy
function of aRoute
once it (orErrorElement
) has mounted. Another approach would be to programatically "retry" by running theimport
promise again, however then we can't show a spinner or a fallback component in the meantime.Test