Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade cli-app-scripts to fix AppHub publishing failure #3393

Merged
merged 6 commits into from
Nov 8, 2024

Conversation

jenniferarnesen
Copy link
Collaborator

@jenniferarnesen jenniferarnesen commented Nov 8, 2024

After the fix for Laos language support to glyphs was added (https://dhis2.atlassian.net/browse/DHIS2-16395), the step to publish the build to AppHub started failing. This is because the build bundle size exceeded that allowed by axios, which is used for posting the bundle to AppHub. The bundle size max was fixed in cli-app-scripts 11.7.5.

This PR also sets @dhis2/ui as a direct dependency so that we control what version is installed instead of depending on cli-app-scripts->app-shell determining the version of @dhis2/ui.

@dhis2-bot
Copy link
Contributor

dhis2-bot commented Nov 8, 2024

🚀 Deployed on https://pr-3393.maps.netlify.dhis2.org

@dhis2-bot dhis2-bot temporarily deployed to netlify November 8, 2024 08:28 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify November 8, 2024 08:32 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify November 8, 2024 08:43 Inactive
@dhis2-bot dhis2-bot temporarily deployed to netlify November 8, 2024 09:04 Inactive
@jenniferarnesen jenniferarnesen changed the title chore: upgrade cli-app-scripts needed for releasing maps chore: upgrade cli-app-scripts to fix AppHub publishing failure Nov 8, 2024
@jenniferarnesen jenniferarnesen merged commit 7f6f777 into master Nov 8, 2024
18 checks passed
@jenniferarnesen jenniferarnesen deleted the chore/upgrade-cli-app-scripts branch November 8, 2024 10:30
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 100.7.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants