Merge pull request #1515 from dhis2/add-test-id-to-sharing-dialog

feat: add data test prop to sharing dialog
dhis2 · Jun 6, 2024 · 1ae38d9 · 1ae38d9
2 parents 2dc0405 + 5a1d81d
commit 1ae38d9
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 4 deletions.
diff --git a/components/sharing-dialog/src/modal/modal.js b/components/sharing-dialog/src/modal/modal.js
@@ -9,7 +9,7 @@ import PropTypes from 'prop-types'
 import React from 'react'
 import i18n from '../locales/index.js'
 
-export const Modal = ({ onClose, name, children }) => {
+export const Modal = ({ onClose, name, children, dataTest }) => {
     const title = name
         ? i18n.t('Sharing and access: {{- objectName}}', {
               objectName: name,
@@ -18,7 +18,7 @@ export const Modal = ({ onClose, name, children }) => {
         : i18n.t('Sharing and access')
 
     return (
-        <Dhis2Modal large position="top" onClose={onClose}>
+        <Dhis2Modal large position="top" onClose={onClose} dataTest={dataTest}>
             <ModalTitle>{title}</ModalTitle>
             <ModalContent>{children}</ModalContent>
             <ModalActions>
@@ -32,8 +32,13 @@ export const Modal = ({ onClose, name, children }) => {
     )
 }
 
+Modal.defaultProps = {
+    dataTest: 'dhis2-uicore-sharingdialog-modal',
+}
+
 Modal.propTypes = {
     children: PropTypes.node.isRequired,
+    dataTest: PropTypes.string,
     name: PropTypes.string,
     onClose: PropTypes.func,
 }
diff --git a/components/sharing-dialog/src/sharing-dialog.js b/components/sharing-dialog/src/sharing-dialog.js
@@ -48,6 +48,7 @@ export const SharingDialog = ({
     onError,
     onSave,
     initialSharingSettings,
+    dataTest,
 }) => {
     const { show: showError } = useAlert((error) => error, { critical: true })
 
@@ -159,7 +160,11 @@ export const SharingDialog = ({
 
     return (
         <FetchingContext.Provider value={mutating || fetching}>
-            <Modal onClose={onClose} name={object.displayName || object.name}>
+            <Modal
+                onClose={onClose}
+                name={object.displayName || object.name}
+                dataTest={dataTest}
+            >
                 <TabbedContent
                     id={id}
                     users={users}
@@ -187,6 +192,7 @@ SharingDialog.defaultProps = {
     onClose: () => {},
     onError: () => {},
     onSave: () => {},
+    dataTest: 'dhis2-uicore-sharingdialog',
 }
 
 SharingDialog.propTypes = {
@@ -199,7 +205,7 @@ SharingDialog.propTypes = {
         EVENT_VISUALIZATION,
         INTERPRETATION,
     ]).isRequired,
-    /** Used to seed the component with data to show whilst loading */
+    dataTest: PropTypes.string,
     initialSharingSettings: PropTypes.shape({
         allowPublic: PropTypes.bool.isRequired,
         groups: PropTypes.objectOf(