chore: remove legacy scripts and GH workflow bandaids

.github/workflows/dhis2-deploy-netlify.yml

@@ -31,7 +31,7 @@ jobs:
             - uses: c-hive/gha-yarn-cache@v1
             - run: yarn install --frozen-lockfile
 
-            - run: yarn build:legacy
+            - run: yarn build
 
             - uses: nwtgck/[email protected]
               with:

.github/workflows/dhis2-preview-pr.yml

@@ -29,7 +29,7 @@ jobs:
             - uses: c-hive/gha-yarn-cache@v1
             - run: yarn install --frozen-lockfile
 
-            - run: yarn build:legacy
+            - run: yarn build
 
             - name: Deploy
               id: netlify-deploy

.github/workflows/dhis2-verify-lib.yml

@@ -44,7 +44,7 @@ jobs:
                   NODE_OPTIONS=--openssl-legacy-provider yarn setup
 
             - name: Build
-              run: yarn build:legacy
+              run: yarn build
 
             - run: ./scripts/create-artifact.sh
 
@@ -147,7 +147,8 @@ jobs:
             - name: End-to-End tests
               uses: cypress-io/github-action@v6
               with:
-                  start: 'yarn cy:start:legacy'
+                  # This should be a command that starts the server to test against.
+                  start: 'yarn cy:start'
                   wait-on: 'http://localhost:5000'
                   wait-on-timeout: 300
                   record: ${{ env.SHOULD_RECORD }}
@@ -185,9 +186,6 @@ jobs:
             # ensure that d2-app-scripts is available
             - run: yarn install --frozen-lockfile
 
-            # FIXME: Add legacy npm to allow our broken peerdeps for now.
-            # This should be addressed properly by fixing our peerdeps.
-            - run: npm i -g npm@6
             - uses: dhis2/action-semantic-release@master
               with:
                   publish-npm: true

package.json

@@ -27,11 +27,9 @@
     "scripts": {
         "setup": "./scripts/setup.js",
         "build": "./scripts/build-world.sh",
-        "build:legacy": "NODE_OPTIONS=--openssl-legacy-provider ./scripts/build-world.sh",
         "build:lib": "./scripts/build.js",
         "build:docs": "./scripts/build-docs.js",
         "build:api": "./scripts/generate-api-docs.js",
-        "cy:start:legacy": "NODE_OPTIONS=--openssl-legacy-provider yarn cy:start",
         "cy:start": "yarn build:lib && STORYBOOK_TESTING=1 yarn start",
         "cy:open": "wait-on 'http://localhost:5000' && cypress open",
         "cy:run": "wait-on 'http://localhost:5000' && cypress run",
@@ -42,7 +40,6 @@
         "lint:staged": "d2-style check --staged",
         "test": "d2-app-scripts test",
         "start": "yarn workspace ui-storybook start",
-        "start:legacy": "NODE_OPTIONS=--openssl-legacy-provider yarn workspace ui-storybook start",
         "start:docs": "yarn workspace ui-docusaurus start"
     },
     "dependencies": {