Merge pull request #1473 from dhis2/fix/button-prop-types

fix(button): fix prop types for button
dhis2 · May 27, 2024 · 46f302c · 46f302c
2 parents 0d6986b + 2e290c7
commit 46f302c
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/components/button/types/index.d.ts b/components/button/types/index.d.ts
@@ -16,7 +16,7 @@ type ButtonOpenEventHandler<
     Event extends React.SyntheticEvent = React.MouseEvent<HTMLButtonElement>
 > = (arg0: ButtonEventPayload & { open: boolean }, event: Event) => void
 
-export interface ButtonProps extends HTMLButtonElement {
+export interface BaseButtonProps {
     /**
      * Component to render inside the button
      */
@@ -102,6 +102,9 @@ export interface ButtonProps extends HTMLButtonElement {
     onKeyDown?: ButtonEventHandler<React.KeyboardEvent<HTMLButtonElement>>
 }
 
+export type ButtonProps = BaseButtonProps &
+    Omit<React.ComponentPropsWithoutRef<'button'>, keyof BaseButtonProps>
+
 export const Button: React.FC<ButtonProps>
 
 export interface ButtonStripProps {