chore: add linting scripts #1176
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-1176--dhis2-ui.netlify.app |
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this solve
When working recently on a feature it was difficult to set up a local development workflow across multiple repos. Allowing a workflow across multiple repos locally allows for early feedback on development work - helping to see changes made locally while reducing the need to publish repos to see how implementation of library might effect another that depends on it.
What this PR presents
This is something I put together to just help me work locally for change across
UIandapp-runtime- The question here is would this be useful to anyone else?This PR is also dependent on changes in the other PR on the
app-runtimerepoI used
yarn linkto create locally linked repos foruiandapp-runtime- links have to be established in all the packages in the dependency monorepo and then all have to be consumed in dependent repo.With this workflow to link the repos
yarn link:allin app-runtimeUIyou run inyarn link:app-runtimeyarn buildand those changes should be available in theUIrepoTo unlink the repos
UIyou run inyarn unlink:app-runtimeUIrunyarn install --forceto reinstall the original libs that the linking replacedapp-runtimerunyarn unlink:allConsiderations
uiandapp-runtimeui- I've only seen this work in the packages I cared about for the HeaderBar work I was doing and I don't know if it will work for all packages inuiuiandapp-runtimethis might stop this workui,app-runtimeandapp-platform- this might have been a dependency issue as stated above