fix(select): adjust clear button #1437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-1437--dhis2-ui.netlify.app |
Passing run #3282 ↗︎
Details:
Review all test suite changes for PR #1437 ↗︎ |
|||||||||||||||
Mohammer5
approved these changes
Dec 14, 2023
tomzemp
approved these changes
Jan 9, 2024
cooper-joe
force-pushed
the
select-clear
branch
from
a608775 to
87c3230
Compare
chore(select): add tooltip to package file
cooper-joe
force-pushed
the
select-clear
branch
from
87c3230 to
06885f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements UX-154
Description
This PR changes the
SingleSelectandMultiSelectclear button to use an icon button rather than aButtonwith text label.clearTextprop is used to populate theTooltipthat appears on hover.Checklist
All points above should be relevant for feature PRs. For bugfixes, some points might not be relevant. In that case, just check them anyway to signal the work is done.
Screenshots
Before:
After:
