chore: accessibility on dropdown button #1460
Conversation
|
🚀 Deployed on https://pr-1460--dhis2-ui.netlify.app |
Chisomchima
changed the title
| await waitFor(() => { | ||
| expect(queryByText(componentText)).not.toBeInTheDocument() | ||
| }) | ||
| }) | ||
| }) |
There was a problem hiding this comment.
Could we have a test that wraps this button in a modal, and make sure that only the dropdown is closed when esc is pressed?
There was a problem hiding this comment.
the escape functionality works well, I also tested it with a Modal @Birkbjo
the question I have is that this fixes one part of the requirements - closing with ESC button. But the other part Similar to changes to Select, a menu opened by a DropdownButton should receive focus when the button is triggered.
Passing run #3370 ↗︎
Details:
Review all test suite changes for PR #1460 ↗︎ |
|||||||||||||||
components/button/src/dropdown-button/__tests__/dropdown-button.test.js
Outdated
Show resolved
Hide resolved
|
@Chisomchima you still haven't handled this requirement from the ticket, right?
|
@kabaros I Have written some tests to cover @Birkbjo concerns but I'll have to move this requirement to this jira ticket |
Chisomchima
force-pushed
the
LIBS-561/dropdownButton-accessibility
branch
2 times, most recently
from
d3e7770 to
681086f
Compare
feat: accessibility on dropdown button chore: test dropdown-button in modal chore: update the test for dropdown button in modal chore: accessibilty fix
Chisomchima
force-pushed
the
LIBS-561/dropdownButton-accessibility
branch
from
681086f to
5b6633b
Compare
|
Ok - can you please make sure the ticket is in the current sprint, and has the accessibility epic as a parent. @Birkbjo would you approve the ticket please if you're happy with it. |
Implements LIBS-561
Description
Implemented LIBS-561 by updating the drowpdownButton component to close on click of the escape button.
Known issues