Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add format to calendar input props #1641

Merged
merged 2 commits into from
Nov 26, 2024
Merged

fix: add format to calendar input props #1641

merged 2 commits into from
Nov 26, 2024

Conversation

flaminic
Copy link
Contributor

Description

simple type fix for calendar input

@flaminic flaminic requested a review from a team as a code owner November 26, 2024 14:09
@dhis2-bot
Copy link
Contributor

dhis2-bot commented Nov 26, 2024 •
edited
Loading

🚀 Deployed on https://pr-1641--dhis2-ui.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify November 26, 2024 14:15 Inactive
@amcgee
Copy link
Member

amcgee commented Nov 26, 2024

@flaminic is it correct that this should only apply to the CalendarInput component and not to Calendar?

See https://github.com/dhis2/ui/blob/master/components/calendar/src/calendar/calendar.js#L73-L94 (no format props, though there's a comment about adding it in the future)
And https://github.com/dhis2/ui/blob/master/components/calendar/src/calendar-input/calendar-input.js (format prop exists and is missing in typings)

@amcgee
Copy link
Member

amcgee commented Nov 26, 2024

One option would be to change export const Calendar: React.FC<CalendarProps> to export const Calendar: React.FC<Omit<CalendarProps, 'format'>>

@flaminic
Copy link
Contributor Author

@flaminic is it correct that this should only apply to the CalendarInput component and not to Calendar?

YES! thank you Austin.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@flaminic
Copy link
Contributor Author

@amcgee i've fixed it if you want to double check again :)

amcgee
amcgee approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@amcgee amcgee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dhis2-bot dhis2-bot temporarily deployed to netlify November 26, 2024 14:55 Inactive
@flaminic flaminic merged commit a436c4f into master Nov 26, 2024
17 checks passed
@flaminic flaminic deleted the add-format-to-calendar-input-props branch November 26, 2024 15:03
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 10.1.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kabaros kabaros kabaros approved these changes

@amcgee amcgee amcgee approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@flaminic @dhis2-bot @amcgee @kabaros