-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Model and Visualizations for Campaign Finance Data #5
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting this in! Overall, everything looks good. Some minor nitpicks are some python linters errors and some formatting inconsistent with the other project code (some functions without two spaces between them, x=y instead of x = y for keyword variable assignment in functions). It looks like the linter does not track this, although keeping the formatting consistent helps with searching the project. You don't need to worry about these as you are coding; just make sure to run the formatter on each file you include in a PR (shift + alt + f or shift + command + f). I made the changes, although I am mentioning them for future PRs.
Another thing I suggest as a todo is to make it easier to see the Contribution amount by increasing the area around the lines that make it appear. It seems like I need to have the tip of my mouse pointer exactly on the line for the pop-up to appear.
Also, make sure to use npm ci instead of npm install when installing new dependencies after pulling.
Major Changes
Dependencies
run
npm install
To-Dos