-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split more things into libraries #7554
Conversation
3d9f1b8
to
ff7c974
Compare
eed4c8c
to
44af477
Compare
d96faef
to
1f5d04d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Splitting headless from engine and endian_write are the only things I found a bit odd.
Besides unit tests headless would also make sens if we implement a game server, maybe that gives some better context.
|
61c6a4a
to
374c6ac
Compare
Pull request was converted to draft
49ed72c
to
8b171be
Compare
sadly a lot graphics related code is spread all over the place |
5871282
to
efab121
Compare
This does not fully address the issue of most everything being a giant library but it's a start. Note that the libraries are OBJECT libraries, so they may (and currently do) contain references to missing symbols. Also fixes the implementation of transitive dependency support for OBJECT libraries.
Apparently required for `std::visit`
Rebased and improved OBJECT library support so now dependencies are placed neatly next to the target definitions. This PR no longer contains any source changes, only the build system changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit annoying having to define the object bounds in a meta language (cmake), but it's nice that we get to carve this up in to more manageable chunks.
This does not fully address the issue of most everything being a giant library but it's a start.
Note that the libraries are OBJECT libraries, so they may (and currently do) contain references to missing symbols.
Also fixes the implementation of transitive dependency support for OBJECT libraries.