Move option change handlers out of options.cpp
#7639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glebm
changed the title
sgOptions -> GetOptions()options.cpp
glebm
force-pushed
the
options
branch
2 times, most recently
from
e3c6e8c to
f702588
Compare
|
Rebased |
|
Rebased |
AJenbo
previously approved these changes
Jan 12, 2025
|
Needs another rebase apparently |
In C++, globals initialization order accross translation units is not defined. Accessing a global via a function ensures that it is initialized. This will be needed for diasurgical#7638, which will statically initialize change handlers after the Options object has been initialized.
|
@AJenbo Rebased |
AJenbo
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit replaces
sgOptionswithGetOptions():In C++, globals initialization order accross translation units is not defined. Accessing a global via a function ensures that it is initialized.
The second commit moves the handlers out of
options.cpp, significantly reducing the amount of dependenciesoptions.cpphas.Fixes #7638