-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Fleshstinger #7071
Open
kphoenix137
wants to merge
8
commits into
diasurgical:master
Choose a base branch
from
kphoenix137:fix-fleshstinger
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix Fleshstinger #7071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DUR and AC have no "add" power, so they figured let's just call it "DUR" instead of "DUR_AMP". It seems like that naming decision caused some confusion as people used DUR as if it meant ADD_DUR. |
AJenbo
previously approved these changes
Apr 17, 2024
Please fix merge conflict |
kphoenix137
force-pushed
the
fix-fleshstinger
branch
from
April 19, 2024 00:00
3b4f427
to
d2ea8f4
Compare
kphoenix137
force-pushed
the
fix-fleshstinger
branch
from
September 17, 2024 22:02
d2ea8f4
to
2dfb527
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yet another potentially controversial PR. This is also related to diasurgical/devilution#64 (comment)
As galaxyhaxz said, Split Skull Shield also had this same problem in the PR demo, where they used
IPL_DUR
instead ofIPL_SETDUR
, resulting in 5% increased durability, a very strange number to set, as it has absolutely no effect. Split Skull Shield was instead changed to have 15 durability, which is its base item durability in the PR demo (10), plus 5 (the original value set forIPL_DUR
). This ended up making it a 1 durability nerf in retail, since they did not modify it to be 16 durability + 5 durability for whenever they buffed Buckler durability to 16.Following this line of logic, I think an accurate assessment would be that Fleshstinger was intended to have +6 durability from the Long Bow durability at this time in development, not +6% durability (+6% durability results in a durability increase of 2. Like what??). Given that it's a Long Bow which in PR demo, had a durability of 20, the intent was likely for this bow to have instead 26 durability.