Increase Max Players to 8

[kphoenix137]

Allows for 8 players in a multiplayer game.

Details:

• All town portals are produced in a straight line
• New arrow colors/exp tag colors changed to differentiate players as much as possible
• Exp tag icons improved

Exp tag icons for players 1-8:

Players 1-8 on the automap:

Players 1-8 highlight:

Potential issues:

• Dungeon entry positions aren't synced ("properly"), so it's possible for players to get stuck if all players enter the level at the same time and don't move from entry position (vanilla problem, made worse by adding more players)
• Desync (More players involved may create a lot more desync as 8 different clients have to agree on things)
• Unable to mute/see the new player slots in the Control Panel (Not enough space to include all players. This could be resolved with a future QoL addition of a Party panel, along the lines of what Diablo 2 offers)

[Maderator3000]

Telling players apart (Players all have the same visual appearance as their vanilla counterparts, so it may be incredibly difficult to tell who is who)

Maybe it's worth adding a display of player nicknames above them for small screen resolutions and some shapes with the appropriate player color for larger resolutions? And add the appropriate key binding to switch the display.

[yuripourre]

Telling players apart (Players all have the same visual appearance as their vanilla counterparts, so it may be incredibly difficult to tell who is who)

Maybe it's worth adding a display of player nicknames above them for small screen resolutions and some shapes with the appropriate player color for larger resolutions? And add the appropriate key binding to switch the display.

I think that's what @kphoenix137 meant when he mentioned:

"This could be resolved with a future QoL addition of a Party panel, along the lines of what Diablo 2 offers"

[kphoenix137]

Telling players apart (Players all have the same visual appearance as their vanilla counterparts, so it may be incredibly difficult to tell who is who)

Maybe it's worth adding a display of player nicknames above them for small screen resolutions and some shapes with the appropriate player color for larger resolutions? And add the appropriate key binding to switch the display.

I think the most intuitive solution (a solution that isn't really in the scope of this PR) would be recoloring each player based on their slot number. This may be controversial however and the proper agreed upon change should be discussed at a later time.

[kphoenix137]

Is there any reason this shouldn't be capped to 1?

[yuripourre]

@kphoenix137 very minor suggestion, is it ok to change the first 4 colors a little?

The orange and red are too close to each other, maybe you could do something like:
Red, blue, yellow, pinkish and then the other colors.

It could be very helpful for colorblind people 🙋

[kphoenix137]

@kphoenix137 very minor suggestion, is it ok to change the first 4 colors a little?

The orange and red are too close to each other, maybe you could do something like: Red, blue, yellow, pinkish and then the other colors.

It could be very helpful for colorblind people 🙋

I would prefer to wait for official color-blind accessible changes to be applied. I think immediately changing orange to a light red would make it more difficult to differentiate for non-color blind people as we'd be using 3 different shades of red. I think a future PR that adds toggle options for different types of color blindness that globally change the palette would be great.