Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monster Pathing Fixes #7703

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kphoenix137
Copy link
Collaborator

Fixes some of the biggest issues with Monster pathing that are most obvious to the player:

  • Monsters getting stuck in Cathedral stair trigger tiles
  • The Butcher getting stuck on obstacles, such as in the wall in his room

The first fix prevents Monster pathing from recognizing Down Stairs, Up Stairs, and Town Warp Stairs as valid options as a part of the planned path.

The second fix gives the Butcher the smarter AiPlanWalk() function for figuring out the best way to the player, as well as refining how direction is obtained. RandomWalk() is included as a fallback in case AiPlanWalk() fails.

@kphoenix137
Copy link
Collaborator Author

Additionally, I would like to point out that removing dungeon generated triggers from monster pathing for all dungeon levels was done for 2 reasons:

  • Pathing into/through trigger tiles doesn't help the monster reach the player (except for Catacombs)
  • Monsters stopping in trigger tiles blocks access to that trigger for the player

@glebm
Copy link
Collaborator

glebm commented Feb 2, 2025

Monsters stopping in trigger tiles blocks access to that trigger for the player

Perhaps trigger tiles should be allowed if they're next to the player?

@Trihedraf
Copy link
Collaborator

Taking away stair locking the butcher will make Ironman way harder. Already can barely shoot through grates anymore.

@kphoenix137
Copy link
Collaborator Author

Monsters stopping in trigger tiles blocks access to that trigger for the player

Perhaps trigger tiles should be allowed if they're next to the player?

Not sure I agree with expanding the trigger to more tiles. Seems like it might be a nuisance.

Taking away stair locking the butcher will make Ironman way harder. Already can barely shoot through grates anymore.

It absolutely will, and can be added to the list of other fixes that have made Ironman harder.

@StephenCWills
Copy link
Member

Not sure I agree with expanding the trigger to more tiles. Seems like it might be a nuisance.

I believe glebm was asking if monsters should be allowed to stand on the trigger tile if the player is next to it. Presumably because it would be awkward if they crowd around it without filling in.

@kphoenix137
Copy link
Collaborator Author

Not sure I agree with expanding the trigger to more tiles. Seems like it might be a nuisance.

I believe glebm was asking if monsters should be allowed to stand on the trigger tile if the player is next to it. Presumably because it would be awkward if they crowd around it without filling in.

Completed

@glebm
Copy link
Collaborator

glebm commented Feb 4, 2025

The code looks good to me now.

This will make the game more difficult but I think this is clearly a bugfix, so I'm in favour of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants