Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MRG] update ignore_ident code for later use too #259

Merged
merged 3 commits into from
Dec 7, 2022
Merged

[MRG] update ignore_ident code for later use too #259

merged 3 commits into from
Dec 7, 2022

Conversation

ctb
Copy link
Member

@ctb ctb commented Dec 7, 2022 •
edited
Loading

Updates #255 with more ignoring. Ref #241.

This PR:

  • adds another check for identifier skipping, in ListGatherGenomes()
  • adds a test of this check for the additional target retrieve_genomes
  • updates the test query "metagenome", GCF_000020205-is-missing.trim.sig.zip, with hashes from GCA_900551275.1, so that there is a non-missing match => makes tests work.

@ctb ctb mentioned this pull request Dec 7, 2022
Open
@ctb ctb merged commit 936fe07 into latest Dec 7, 2022
@ctb ctb deleted the update/ignore_ident branch December 7, 2022 14:56
@ctb ctb mentioned this pull request Dec 18, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ctb