-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat optimize #763
Open
xiaoAriana
wants to merge
79
commits into
didi:dev
Choose a base branch
from
xiaoAriana:feat_optimize
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feat optimize #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: 🧨 agree && popup && dialog
提交PR前
创建PR
请把以上内容删除,并填写以下内容!!!
背景描述
1、苹果唤起软键盘后,页面会被向上顶出一块空白,收起后该空白不会自动消失。业界通用的做法时监听输入框的 focus、blur 事件,手动在键盘收起时将页面滚动到顶部。这两个组件没有提供这两个事件,无法做此修复
2、基础组件内的组件存在替换图标的诉求,目前无法满足
3、弹起 popup 后,滚动组件内部到底部后,body 会接着滚动
主要改动
1.agree 支持自定义图标
2.对popup内容过长支持滚动
3.codebox抛出blur事件供业务处理逻辑
需要注意