-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the receiver CPOs (set_value, set_error, set_stopped) #6
Open
dietmarkuehl
wants to merge
6
commits into
main
Choose a base branch
from
receiver
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,221
−21
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
66f96bc
added set_stopped
dietmarkuehl 08d0dad
added set_error implementation
dietmarkuehl e2ccfe5
added set_value implementation
dietmarkuehl ab368c2
fixed year on copyright
dietmarkuehl 522e8d4
added some clarification to the README.md
dietmarkuehl 37d75d7
addressed review comments
dietmarkuehl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,57 @@ | ||
// include/p2300/set_error.hpp -*-C++-*- | ||
// ---------------------------------------------------------------------------- | ||
// Copyright (C) 2022 Dietmar Kuehl http://www.dietmar-kuehl.de | ||
// | ||
// Permission is hereby granted, free of charge, to any person | ||
// obtaining a copy of this software and associated documentation | ||
// files (the "Software"), to deal in the Software without restriction, | ||
// including without limitation the rights to use, copy, modify, | ||
// merge, publish, distribute, sublicense, and/or sell copies of | ||
// the Software, and to permit persons to whom the Software is | ||
// furnished to do so, subject to the following conditions: | ||
// | ||
// The above copyright notice and this permission notice shall be | ||
// included in all copies or substantial portions of the Software. | ||
// | ||
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, | ||
// EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES | ||
// OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND | ||
// NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT | ||
// HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, | ||
// WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING | ||
// FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR | ||
// OTHER DEALINGS IN THE SOFTWARE. | ||
// ---------------------------------------------------------------------------- | ||
|
||
#ifndef INCLUDED_INCLUDE_P2300_SET_ERROR | ||
#define INCLUDED_INCLUDE_P2300_SET_ERROR | ||
|
||
#include <functional> | ||
#include <utility> | ||
|
||
// ---------------------------------------------------------------------------- | ||
|
||
namespace std { | ||
namespace _Set_error { | ||
class _Cpo { | ||
public: | ||
template <class _Receiver, class _Error> | ||
requires nothrow_tag_invocable<_Cpo, _Receiver, _Error> | ||
auto operator()(_Receiver&& __receiver, _Error&& __error) const noexcept -> void | ||
{ | ||
std::tag_invoke(*this, std::forward<_Receiver>(__receiver), std::forward<_Error>(__error)); | ||
} | ||
}; | ||
} | ||
|
||
namespace execution { | ||
using set_error_t = _Set_error::_Cpo; | ||
inline namespace _Cpos { | ||
inline constexpr set_error_t set_error{}; | ||
} | ||
} | ||
} | ||
|
||
// ---------------------------------------------------------------------------- | ||
|
||
#endif |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,58 @@ | ||
// include/p2300/set_stopped.hpp -*-C++-*- | ||
// ---------------------------------------------------------------------------- | ||
// Copyright (C) 2022 Dietmar Kuehl http://www.dietmar-kuehl.de | ||
// | ||
// Permission is hereby granted, free of charge, to any person | ||
// obtaining a copy of this software and associated documentation | ||
// files (the "Software"), to deal in the Software without restriction, | ||
// including without limitation the rights to use, copy, modify, | ||
// merge, publish, distribute, sublicense, and/or sell copies of | ||
// the Software, and to permit persons to whom the Software is | ||
// furnished to do so, subject to the following conditions: | ||
// | ||
// The above copyright notice and this permission notice shall be | ||
// included in all copies or substantial portions of the Software. | ||
// | ||
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, | ||
// EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES | ||
// OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND | ||
// NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT | ||
// HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, | ||
// WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING | ||
// FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR | ||
// OTHER DEALINGS IN THE SOFTWARE. | ||
// ---------------------------------------------------------------------------- | ||
|
||
#ifndef INCLUDED_INCLUDE_P2300_SET_STOPPED | ||
#define INCLUDED_INCLUDE_P2300_SET_STOPPED | ||
|
||
#include <functional> | ||
#include <utility> | ||
|
||
// ---------------------------------------------------------------------------- | ||
// [exec.set_stopped] | ||
|
||
namespace std { | ||
namespace _Set_stopped { | ||
class _Cpo { | ||
public: | ||
template <class _Receiver> | ||
requires nothrow_tag_invocable<_Cpo, _Receiver> | ||
auto operator()(_Receiver&& __receiver) const noexcept -> void | ||
{ | ||
std::tag_invoke(*this, std::forward<_Receiver>(__receiver)); | ||
} | ||
}; | ||
} | ||
|
||
namespace execution { | ||
using set_stopped_t = _Set_stopped::_Cpo; | ||
inline namespace _Cpos { | ||
inline constexpr set_stopped_t set_stopped{}; | ||
} | ||
} | ||
} | ||
|
||
// ---------------------------------------------------------------------------- | ||
|
||
#endif |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,58 @@ | ||
// include/p2300/set_value.hpp -*-C++-*- | ||
// ---------------------------------------------------------------------------- | ||
// Copyright (C) 2022 Dietmar Kuehl http://www.dietmar-kuehl.de | ||
// | ||
// Permission is hereby granted, free of charge, to any person | ||
// obtaining a copy of this software and associated documentation | ||
// files (the "Software"), to deal in the Software without restriction, | ||
// including without limitation the rights to use, copy, modify, | ||
// merge, publish, distribute, sublicense, and/or sell copies of | ||
// the Software, and to permit persons to whom the Software is | ||
// furnished to do so, subject to the following conditions: | ||
// | ||
// The above copyright notice and this permission notice shall be | ||
// included in all copies or substantial portions of the Software. | ||
// | ||
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, | ||
// EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES | ||
// OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND | ||
// NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT | ||
// HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, | ||
// WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING | ||
// FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR | ||
// OTHER DEALINGS IN THE SOFTWARE. | ||
// ---------------------------------------------------------------------------- | ||
|
||
#ifndef INCLUDED_INCLUDE_P2300_SET_VALUE | ||
#define INCLUDED_INCLUDE_P2300_SET_VALUE | ||
|
||
#include <functional> | ||
#include <utility> | ||
|
||
// ---------------------------------------------------------------------------- | ||
|
||
namespace std { | ||
namespace _Set_value { | ||
class _Cpo { | ||
public: | ||
template <class _Receiver, class... _Args> | ||
requires nothrow_tag_invocable<_Cpo, _Receiver, _Args...> | ||
auto operator()(_Receiver&& __receiver, _Args&&... __args) const noexcept -> void | ||
{ | ||
std::tag_invoke(*this, std::forward<_Receiver>(__receiver), std::forward<_Args>(__args)...); | ||
} | ||
}; | ||
} | ||
|
||
namespace execution { | ||
using set_value_t = _Set_value::_Cpo; | ||
inline namespace _Cpos { | ||
inline constexpr set_value_t set_value{}; | ||
} | ||
} | ||
} | ||
|
||
|
||
// ---------------------------------------------------------------------------- | ||
|
||
#endif |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we do not go with
receiver
should we then constraint withmovable-value
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe - that would need to go into the specification, though. The current specification just says "for some subexpression
R
" without adding any requirements onR
. I believe the implementation allowing (and testing) the different lvalue overloads is as specified. An implementation not passing these tests does not match the specification.