Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update default versions for Eclipse Java and Groovy formatters #2381

Merged
merged 4 commits into from
Jan 6, 2025

Conversation

jochenberger
Copy link
Contributor

No description provided.

@jochenberger
Copy link
Contributor Author

See also #2286

@jochenberger
Copy link
Contributor Author

java.lang.IllegalArgumentException: Expected endsWith /content.xml but was https://groovy.jfrog.io/artifactory/plugins-release/org/codehaus/groovy/groovy-eclipse-integration/5.6.0/e4.34/content.xml.xz
      at com.diffplug.spotless.extra.groovy.GrEclipseFormatterStepSpecialCaseTest.issue_1657_fixed(GrEclipseFormatterStepSpecialCaseTest.java:41)

🤔

@nedtwigg
Copy link
Member

nedtwigg commented Jan 6, 2025

Bummer. My vote is:

  • change this PR to update JDT only
  • one or both of:
    • file bug at Equo about support for content.xml.xz
    • ask Greclipse if they can publish a content.xml, instead of only content.xml.xz
  • once one of those gets resolved, then we can bump Greclipse support again

At least Eclipse signing metadata is consistent again for 4.34! They fixed a ton of SWT on GTK issues since 4.32, so I'm happy to see some parts of the Eclipse project working relatively well.

@jochenberger
Copy link
Contributor Author

Sounds good to me. I can take care of that tomorrow (UTC+1).

@nedtwigg
Copy link
Member

nedtwigg commented Jan 6, 2025

I just reverted the greclipse bump and updated the changelog. 7.0.0 finally releases today!

@nedtwigg nedtwigg merged commit 719f9a4 into diffplug:main Jan 6, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants