Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed np.fft.fftn() deprecation #60

Merged
merged 3 commits into from
Nov 9, 2024
Merged

Conversation

cadenmyers13
Copy link
Contributor

closes #22 Fix numpy2 deprecation by specifying axes. Discussed on this PR #56. More specifically, on this comment #56 (comment)

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.49%. Comparing base (46c65be) to head (ad41ea3).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #60   +/-   ##
=======================================
  Coverage   93.49%   93.49%           
=======================================
  Files           4        4           
  Lines         169      169           
=======================================
  Hits          158      158           
  Misses         11       11           

@cadenmyers13
Copy link
Contributor Author

@sbillinge I think this is failing because the codecov thing again... @bobleesj can you confirm this?

@bobleesj
Copy link
Contributor

bobleesj commented Nov 8, 2024

@sbillinge I think this is failing because the codecov thing again... @bobleesj can you confirm this?

@cadenmyers13 yes, pytest runs, it's the codecov upload problem. Could you please try pushing an empty commit? I wonder if it fixes it. Then, I will look into it a bit further.

git commit --allow-empty -m "Re-run CI for codecov report" and then git push as usually.

@sbillinge
Copy link
Contributor

@cadenmyers13 ?

@cadenmyers13
Copy link
Contributor Author

@sbillinge @bobleesj all good

@sbillinge sbillinge merged commit 908992d into diffpy:main Nov 9, 2024
5 checks passed
@sbillinge
Copy link
Contributor

thanks @cadenmyers13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve Pytest 25 warnings
3 participants