Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove conda recipe files (re-open once srfit available on conda-forge) #85

Closed
wants to merge 2 commits into from
Closed

Remove conda recipe files (re-open once srfit available on conda-forge) #85

wants to merge 2 commits into from

Conversation

bobleesj
Copy link

Conda recipe files are moved in the current repo since they are managed in a separate folder:

conda-forge/staged-recipes#25665

sbillinge
sbillinge reviewed Sep 13, 2024
View reviewed changes
Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

before we delete these, are we sure that we have the meta.yaml information all saved somewhere (e.g., in release-scripts or the cf feedstock, so we don't lose useful information? Once confrmed I iwll merge this.

@bobleesj
Copy link
Author

I noticed that the meta.yml file in the diffpy.srfit conda-forge recipe under review is different from what is provided here: conda-forge/staged-recipes#25665. So no merge at the moment.. (yet)

Seems like we already have diffpy.srfit conda package available here: https://anaconda.org/diffpy/diffpy.srfit, but it's not via the conda-forge channel.

Shall we wait to delete these files once we have diffpy.srfit available on conda-forge? @sbillinge

@sbillinge
Copy link
Contributor

I noticed that the meta.yml file in the diffpy.srfit conda-forge recipe under review is different from what is provided here: conda-forge/staged-recipes#25665. So no merge at the moment.. (yet)

Seems like we already have diffpy.srfit conda package available here: https://anaconda.org/diffpy/diffpy.srfit, but it's not via the conda-forge channel.

Shall we wait to delete these files once we have diffpy.srfit available on conda-forge? @sbillinge

yes. Let's capture that in an issue so we remember to revisit....

@bobleesj bobleesj mentioned this pull request Sep 13, 2024
Open
@bobleesj
Copy link
Author

I noticed that the meta.yml file in the diffpy.srfit conda-forge recipe under review is different from what is provided here: conda-forge/staged-recipes#25665. So no merge at the moment.. (yet)
Seems like we already have diffpy.srfit conda package available here: https://anaconda.org/diffpy/diffpy.srfit, but it's not via the conda-forge channel.
Shall we wait to delete these files once we have diffpy.srfit available on conda-forge? @sbillinge

yes. Let's capture that in an issue so we remember to revisit....

#86

Yes

@bobleesj
Copy link
Author

bobleesj commented Sep 13, 2024 •
edited
Loading

Will re-open once we have diffpy.srfit feedstock, reviewed and available via conda-forge.

@bobleesj bobleesj closed this Sep 13, 2024
@bobleesj bobleesj changed the title Remove conda recipe files Remove conda recipe files (re-open once srfit available on conda-forge) Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbillinge sbillinge sbillinge left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bobleesj @sbillinge