bug: cookie is not set if the host address is localhost:4320 #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's pull this one into master |
|
I added some comments can you see them?
…On Sat, 18 May 2024, 11:46 m-fedosov, ***@***.***> wrote:
Let's pull this one into master
—
Reply to this email directly, view it on GitHub
<#632 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA4SWL6PN4XZ35GCOA2IVDZC4WQ3AVCNFSM6AAAAABHRZAEQ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJYG43TGNBXGQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
Hmm, I don't see any comments. |
|
Odd, I'll try again tomorrow then.
…On Sun, 19 May 2024, 21:25 m-fedosov, ***@***.***> wrote:
Hmm, I don't see any comments.
—
Reply to this email directly, view it on GitHub
<#632 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA4SWN3CFD5J3MQR74VBD3ZDEDCLAVCNFSM6AAAAABHRZAEQ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJZGM2DSOJUHE>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
digininja
reviewed
May 20, 2024
| @@ -4,6 +4,7 @@ | |||
|
|
|||
| if ($_SERVER['REQUEST_METHOD'] == "POST") { | |||
| $cookie_value = sha1(mt_rand() . time() . "Impossible"); | |||
| setcookie("dvwaSession", $cookie_value, time()+3600, "/vulnerabilities/weak_id/", $_SERVER['HTTP_HOST'], true, true); | |||
| $domain = ($_SERVER['SERVER_NAME'] != 'localhost') ? $_SERVER['HTTP_HOST'] : false; | |||
There was a problem hiding this comment.
Why aren't you setting it if it is localhost?
The default according to the manual should be an empty string, not false.
Would it make sense to do an equals check and reverse the two value fields? That would read better to me.
|
I hadn't clicked enough save buttons. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solution is better than #631 since it sets a cookie even on a subdomain