fix: set hashlib's usedforsecurity=False to prevent weak hash #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
This PR is for a security issue identified by the security scanner, a high priority issue related to the use of weak SHA-1 hashing for security purposes in our codebase. SHA-1 is considered insecure for cryptographic operations. SHA-1 is used in the codebase for cache-busting, which is not a security-sensitive task. To prevent the security scanner from flagging this as a vulnerability, we explicitly set
usedforsecurity=Falsein all instances where SHA-1 is used for non-security tasks.Related Tickets & Documents
Added/updated tests?
We encourage you to keep the code coverage percentage at 80% and above.
usedforsecurity=Falsedoesn't change anything, so no new tests are needed.