-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DR2-2078 Add JSON output #1166
Open
MancunianSam
wants to merge
4
commits into
main
Choose a base branch
from
DR2-2078-add-json-output
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
DR2-2078 Add JSON output #1166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can be used on the CLI by passing the --json flag or through a new radio button group on the export dialog. I also used a java 21 switch statement which meant I needed to upgrade the checkstyle plugins which then meant there were errors which were ignored before so I've fixed these rather than trying to suppress them.
757c9e7
to
5258c18
Compare
sparkhi
reviewed
Feb 4, 2025
droid-swing-ui/src/main/resources/uk/gov/nationalarchives/droid/gui/export/Bundle.properties
Outdated
Show resolved
Hide resolved
sparkhi
reviewed
Feb 5, 2025
...mand-line/src/main/java/uk/gov/nationalarchives/droid/command/action/CommandFactoryImpl.java
Show resolved
Hide resolved
sparkhi
reviewed
Feb 5, 2025
droid-command-line/src/main/java/uk/gov/nationalarchives/droid/command/i18n/I18N.java
Outdated
Show resolved
Hide resolved
sparkhi
reviewed
Feb 5, 2025
...ommand-line/src/main/java/uk/gov/nationalarchives/droid/command/action/CommandLineParam.java
Outdated
Show resolved
Hide resolved
sparkhi
reviewed
Feb 5, 2025
...ommand-line/src/main/java/uk/gov/nationalarchives/droid/command/action/CommandLineParam.java
Show resolved
Hide resolved
sparkhi
reviewed
Feb 5, 2025
...ts/src/main/java/uk/gov/nationalarchives/droid/profile/datawriter/ColumnBasedDataWriter.java
Show resolved
Hide resolved
sparkhi
reviewed
Feb 5, 2025
droid-swing-ui/src/main/java/uk/gov/nationalarchives/droid/gui/export/ExportDialog.java
Outdated
Show resolved
Hide resolved
sparkhi
reviewed
Feb 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and works too. I've left a few inline comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be used on the CLI by passing the --json flag or through a new
radio button group on the export dialog.
I also used a java 21 switch statement which meant I needed to upgrade
the checkstyle plugins which then meant there were errors which were
ignored before so I've fixed these rather than trying to suppress them.