Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a fallback global scope for runtime likes wechat mini program #1066

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

imyelo
Copy link

@imyelo imyelo commented Dec 21, 2023

WeChat Mini Program is a popular application form in China, similar to Progressive Web Apps but with a specific runtime and system interface provided by the application platform (wechat indeeded). Its runtime is similar to a browser or React Native but lacks global objects like document, window, self. As a result, using node-forge in WeChat Mini Program would cause crashes due to the inability to find the global scope, leading to issues like #1028 and #1027.

A few years ago, I made some minor efforts to support running such JavaScript modules in those environments, including applying a runtime patch for JS dependencies. However, this implementation heavily depends on webpack.

Especially with the popularity of various mini programs and cross-platform frameworks today, I believe that adding a fallback logic directly in node-forge can prevent crashes in such scenarios.

Hope this will be helpful for other mini program or hybrid developers as well. 😘

@vricosti
Copy link

completely agree!!!
I have the same kind of issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants