Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1774: Move translations to translations file #1841

Merged
merged 6 commits into from
Jan 22, 2025

Conversation

ztefanie
Copy link
Member

@ztefanie ztefanie commented Dec 17, 2024

Short description

Moved translations to translations file

Proposed changes

  • added translations for bp-modules in de.json

Side effects

  • may break everything

Testing

Check all features and check if all labels everywhere are displayed correctly.
At least:

  • Statistics
  • Region verwalten
  • Projekt verwalten
  • Koblenz Self Service
  • AcceptanceStore import
  • Benutzerverwaltung

Resolved issues

partially fixes: #1774

Note
MUI modules are missing and will be implemented in a follow up pr

@ztefanie ztefanie force-pushed the 1774-move-german-translation-to-translation-file branch from 34e93cc to 8112f50 Compare December 18, 2024 08:13
@f1sh1918 f1sh1918 self-assigned this Jan 14, 2025
…slation-to-translation-file

# Conflicts:
#	administration/src/bp-modules/applications/JsonFieldElemental.tsx
#	administration/src/bp-modules/applications/VerificationsView.tsx
#	administration/src/bp-modules/user-settings/ActivityLogCard.tsx
#	administration/src/util/translations/de.json
@f1sh1918 f1sh1918 removed their assignment Jan 14, 2025
@f1sh1918
Copy link
Contributor

@seluianova , @steffenkleinle and @bahaaTuffaha
i updated the pr due to some merge conflicts and fixed some minor issue

Not sure if should then review this :)

@bahaaTuffaha
Copy link
Contributor

Initially I searched most components for any German words within (bp-modules) I found these:

administration/src/bp-modules/applications/JsonFieldElemental.tsx (ja ,Nein)
administration/src/bp-modules/applications/VerificationsView.tsx (Bestätigung(en) durch Organisationen)
administration/src/bp-modules/auth/LoginForm.tsx (Passwort vergessen , text='Anmelden')
administration/src/bp-modules/users/EditUserDialog.tsx (ownAccountWarningConfirmation duplicated)
administration/src/bp-modules/users/UsersTable.tsx (Rolle)
administration/src/bp-modules/cards/CreateCardsButtonBar.tsx (text='Zurück zur Auswahl' ,text='QR-Codes drucken')
administration/src/bp-modules/ErrorHandler.tsx (title = 'Ein Fehler ist aufgetreten.')
administration/src/bp-modules/statistics/components/StatisticsTotalCardsCount.tsx (Alle Regionen)
administration/src/bp-modules/users/CreateUserDialog.tsx (label='Email-Adresse')

@f1sh1918
Copy link
Contributor

Initially I searched most components for any German words within (bp-modules) I found these:

administration/src/bp-modules/applications/JsonFieldElemental.tsx (ja ,Nein) administration/src/bp-modules/applications/VerificationsView.tsx (Bestätigung(en) durch Organisationen) administration/src/bp-modules/auth/LoginForm.tsx (Passwort vergessen , text='Anmelden') administration/src/bp-modules/users/EditUserDialog.tsx (ownAccountWarningConfirmation duplicated) administration/src/bp-modules/users/UsersTable.tsx (Rolle) administration/src/bp-modules/cards/CreateCardsButtonBar.tsx (text='Zurück zur Auswahl' ,text='QR-Codes drucken') administration/src/bp-modules/ErrorHandler.tsx (title = 'Ein Fehler ist aufgetreten.') administration/src/bp-modules/statistics/components/StatisticsTotalCardsCount.tsx (Alle Regionen) administration/src/bp-modules/users/CreateUserDialog.tsx (label='Email-Adresse')

thx for all the findings. i added translations and fixed one test

Copy link
Contributor

@seluianova seluianova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked out everything I could think of, couldn't find any issues (anyway I believe it's not a big deal if something came up later and we fix it separately).
Thanks for this huge effort @ztefanie and @f1sh1918 :)

Copy link
Contributor

@bahaaTuffaha bahaaTuffaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 🚀.. I tested most of the places that needed testing + looked for words within bp-modules all works as expected.

@f1sh1918 f1sh1918 merged commit a962016 into main Jan 22, 2025
2 checks passed
@f1sh1918 f1sh1918 deleted the 1774-move-german-translation-to-translation-file branch January 22, 2025 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add all german texts to translation file
4 participants