-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1774: Move translations to translations file #1841
1774: Move translations to translations file #1841
Conversation
34e93cc
to
8112f50
Compare
…slation-to-translation-file # Conflicts: # administration/src/bp-modules/applications/JsonFieldElemental.tsx # administration/src/bp-modules/applications/VerificationsView.tsx # administration/src/bp-modules/user-settings/ActivityLogCard.tsx # administration/src/util/translations/de.json
@seluianova , @steffenkleinle and @bahaaTuffaha Not sure if should then review this :) |
Initially I searched most components for any German words within (bp-modules) I found these:
|
thx for all the findings. i added translations and fixed one test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work 🚀.. I tested most of the places that needed testing + looked for words within bp-modules all works as expected.
Short description
Moved translations to translations file
Proposed changes
Side effects
Testing
Check all features and check if all labels everywhere are displayed correctly.
At least:
Resolved issues
partially fixes: #1774
Note
MUI modules are missing and will be implemented in a follow up pr