1865: Custom application created confirmation mail #1872

f1sh1918 · 2025-01-20T13:06:10Z

Short description

As a trainer from verein360, i want to receive a confirmation mail for my application i sent for an applicatant.
Background: For verein360 not the applicant him/herself creates application but the trainer for him/her.
So the confirmation mail should not be send to the applicant but to the creator of the application in this case the trainer.

Proposed changes

if the application was send by verein360 and is pre verified send an e mail to the contact person/trainer of the organization.

Side effects

none

Testing

send an application request (graphiql or postman) using a mail address as contact person that you own (to check that you receive the mail)
Example for an graphql mutation you can find here: 1816: Input validation for application endpoint #1863

Resolved issues

Fixes: #1865

f1sh1918 · 2025-01-20T13:07:18Z

...rc/main/kotlin/app/ehrenamtskarte/backend/application/webservice/utils/ApplicationHandler.kt

+        val backendConfig = context.backendConfiguration
+        val projectConfig = backendConfig.projects.first { it.id == project }
+
+        for (applicationVerification in verificationEntities) {


even we should only have one organization in this case for verein360, in theory there could be more organization that would all receive this e-mail.

f1sh1918 · 2025-01-20T13:07:47Z

backend/src/main/kotlin/app/ehrenamtskarte/backend/mail/Mailer.kt

@@ -19,7 +19,7 @@ import java.nio.charset.StandardCharsets

 object Mailer {
    private const val DO_NOT_ANSWER_MESSAGE =
-        "Dies ist eine automatisierte Nachricht. Bitte antworten Sie nicht auf diese Email."


ui/ux proposed to change the text, so i made a general change for all mails

seluianova · 2025-01-21T16:45:23Z

backend/src/main/kotlin/app/ehrenamtskarte/backend/mail/Mailer.kt

+            }
+            p { +"Bei Rückfragen wenden Sie sich bitte direkt an Ihr zuständiges Landratsamt oder die Verwaltung Ihrer kreisfreien Stadt." }
+            p { +DO_NOT_ANSWER_MESSAGE }
+            p { +"- ${projectConfig.administrationName}" }


"Mit freundlichen Grüßen" is missing (was in the Toni's suggestion)
not sure if it must be included

alright good find. but then we should add this to all mails

seluianova

lgtm! thx for the quick fix :)

steffenkleinle

Code looks good, however, I did not receive any email. I retried with a different email address but to no avail. Any ideas?

f1sh1918 · 2025-01-22T14:45:40Z

Code looks good, however, I did not receive any email. I retried with a different email address but to no avail. Any ideas?

did you create a proper config.local.yml or there may be an updated doc with a local config file in you user folder. Just check the documentation. Let me know if i you need help @steffenkleinle

f1sh1918 · 2025-01-22T15:15:34Z

@seluianova i added a finalInformationParagraph to ensure that the text is equal in all mails. Maybe you can just check if the mail is still ok

seluianova · 2025-01-22T15:47:24Z

I did not receive any email. I retried with a different email address but to no avail. Any ideas?

@steffenkleinle do you see the email in the log? I don't have smtp configured and have only been checking the logs the whole time, assuming it's enough (isn't it?)

i added a finalInformationParagraph to ensure that the text is equal in all mails. Maybe you can just check if the mail is still ok

@f1sh1918 I double checked, looks good!

steffenkleinle

Tested, thanks for the help. I didn't have anything configured

f1sh1918 · 2025-01-25T17:56:47Z

@seluianova @steffenkleinle
You should configure it soon since you should also be able to check if the template breaks or not for any reason

seluianova · 2025-01-27T10:23:53Z

You should configure it soon since you should also be able to check if the template breaks or not for any reason

I think it's quite "safe" from that point of view, because sent emails are printed in the log

[JettyServerThreadPool-38] INFO app.ehrenamtskarte.backend.mail.Mailer - Sending Email:
FromName: Ehrenamtskarte-Bayern-Verwaltung
To: <my-email>
Subject: Antrag erfolgreich eingereicht
-----------------------
Sehr geehrte/r Jane Doe,

Ihr Antrag auf die Bayerische Ehrenamtskarte für John Doe wurde erfolgreich eingereicht.

Den aktuellen Status Ihres Antrags können sie jederzeit unter folgendem Link einsehen. Dort haben Sie auch die Möglichkeit, Ihren Antrag bei Bedarf zurückzuziehen:
https://bayern.ehrenamtskarte.app/antrag-einsehen/ohv35qtAhuQZU22Yo_1aZEUr-qjqF59cQdCJpmkrnjBOOzZn3JBY1Lbfr6yrRXsHs-SL2_rhNc51a_6l8k1IVA%3D%3D 

Bei Rückfragen wenden Sie sich bitte direkt an Ihr zuständiges Landratsamt oder die Verwaltung Ihrer kreisfreien Stadt.

Bitte beachten Sie, dass dies eine automatisierte Nachricht ist. Antworten auf diese E-Mail werden nicht gelesen.

Mit freundlichen Grüßen
- Ehrenamtskarte-Bayern-Verwaltung

1865: send pre verified application mail to contact person

e3b7240

f1sh1918 requested review from steffenkleinle, ztefanie and seluianova as code owners January 20, 2025 13:06

f1sh1918 commented Jan 20, 2025

View reviewed changes

seluianova reviewed Jan 21, 2025

View reviewed changes

seluianova approved these changes Jan 21, 2025

View reviewed changes

steffenkleinle reviewed Jan 22, 2025

View reviewed changes

1660: final information section

aa4621f

steffenkleinle approved these changes Jan 23, 2025

View reviewed changes

f1sh1918 merged commit ee262ff into main Jan 27, 2025
2 checks passed

f1sh1918 deleted the 1865-custom-application-created-confirmation-mail branch January 27, 2025 14:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

1865: Custom application created confirmation mail #1872

1865: Custom application created confirmation mail #1872

f1sh1918 commented Jan 20, 2025

f1sh1918 Jan 20, 2025

f1sh1918 Jan 20, 2025

seluianova Jan 21, 2025 •

edited

Loading

f1sh1918 Jan 22, 2025

seluianova left a comment •

edited

Loading

steffenkleinle left a comment

f1sh1918 commented Jan 22, 2025 •

edited

Loading

f1sh1918 commented Jan 22, 2025

seluianova commented Jan 22, 2025 •

edited

Loading

steffenkleinle left a comment

f1sh1918 commented Jan 25, 2025

seluianova commented Jan 27, 2025 •

edited

Loading

1865: Custom application created confirmation mail #1872

1865: Custom application created confirmation mail #1872

Conversation

f1sh1918 commented Jan 20, 2025

Short description

Proposed changes

Side effects

Testing

Resolved issues

f1sh1918 Jan 20, 2025

Choose a reason for hiding this comment

f1sh1918 Jan 20, 2025

Choose a reason for hiding this comment

seluianova Jan 21, 2025 • edited Loading

Choose a reason for hiding this comment

f1sh1918 Jan 22, 2025

Choose a reason for hiding this comment

seluianova left a comment • edited Loading

Choose a reason for hiding this comment

steffenkleinle left a comment

Choose a reason for hiding this comment

f1sh1918 commented Jan 22, 2025 • edited Loading

f1sh1918 commented Jan 22, 2025

seluianova commented Jan 22, 2025 • edited Loading

steffenkleinle left a comment

Choose a reason for hiding this comment

f1sh1918 commented Jan 25, 2025

seluianova commented Jan 27, 2025 • edited Loading

seluianova Jan 21, 2025 •

edited

Loading

seluianova left a comment •

edited

Loading

f1sh1918 commented Jan 22, 2025 •

edited

Loading

seluianova commented Jan 22, 2025 •

edited

Loading

seluianova commented Jan 27, 2025 •

edited

Loading