Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1850: Fix multi card activation #1876

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Conversation

f1sh1918
Copy link
Contributor

@f1sh1918 f1sh1918 commented Jan 21, 2025

Short description

This pr fixes the issue that the same card could be activated twice on the same device, even the first card is changing to an invalid state. Basically if the same card is already activated on this device, the user shouldn't be able to activate it again.

Proposed changes

  • add a deep equality check for the peppers lists ton ensure same cards are correctly identified

Side effects

  • none

Testing

  1. Create a card for nuernberg or koblenz (where multiple cards can be activated)
  2. Activate the card once. Then use the same qr code and try to activate the same card
  3. There should be a message, that the card is already activated on your device

Resolved issues

Fixes: #1850

@f1sh1918 f1sh1918 added the Bug Something isn't working label Jan 21, 2025
Copy link
Contributor

@seluianova seluianova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested deeplink and normal activation on android emulator, looks good!
Thanks for the fix 👍

Copy link
Member

@steffenkleinle steffenkleinle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on android, works as expected

@f1sh1918 f1sh1918 merged commit beb4494 into main Jan 27, 2025
2 checks passed
@f1sh1918 f1sh1918 deleted the 1850-fix-card-multi-activation branch January 27, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Card can be added multiple times on the same device
3 participants