Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2558: Upgrade to Xcode 16 #3003

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

2558: Upgrade to Xcode 16 #3003

wants to merge 7 commits into from

Conversation

LeandraH
Copy link
Contributor

@LeandraH LeandraH commented Nov 23, 2024

Short description

This PR upgrades from Xcode 15 to 16. I had been hoping that we could remove the script with the workaround for the duplicate signature files but it's unfortunately still necessary.

Proposed changes

  • Updated the Xcode version in the CircleCI build files
  • Updated the shell script with the workaround for the duplicate signatures to work for Xcode versions >= 15

Side effects

  • Hopefully none

Testing

Check out that the iOS build worked here: https://app.circleci.com/pipelines/github/digitalfabrik/integreat-app/12716/workflows/842c2297-e823-414f-93b6-bb3817b4a40b/jobs/68092 (Or trigger another build yourself, if you prefer)

Resolved issues

Does not fix: #2558
Fixes: #2813


@f1sh1918
Copy link
Contributor

Looks good so far with Xcode 16.0

@steffenkleinle
Copy link
Member

@LeandraH what is the status on this? Are you still working on it?

@LeandraH LeandraH marked this pull request as ready for review February 5, 2025 17:21
Copy link
Member

@steffenkleinle steffenkleinle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, building worked fine on xcode 16.1 already even without this actually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NSExpression function is forbidden Upgrade XCode and remove mapbox certificate build script
3 participants