-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3060: KebabMenu - Aligned CloseButton based on Position of Expand Button #3072
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing, thank you for your first PR with us! It looks pretty good already, except I think you positioned the closing icon on a page without a scroll bar. When I open it on a page with scrollbar, the closing icon is still a little bit off from where the kebob icon was.
Screen.Recording.2025-02-05.at.15.48.51.mov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congrats and thanks a lot for your first contribution 🎉 😍 Nice work, works and looks as expected! Tested on firefox :)
💭 Unrelated to your PR and does not need to be done here: I think the hit targets are quite small, perhaps we should improve add some padding around the icons to increase the button size a bit?
I am also not able to reproduce this neither on firefox desktop nor mobile (or if so, only negligible). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then I think we're good to go :)
You can now click "Update branch" in this PR, and then enable auto-merge 🎉 Or alternatively, you can click "Update branch", wait for that to be finished, and then click to merge the PR. |
Short description
I aligned the close button with the expand button and changed the height of the header, so that now the KebapMenu Header has the same height as the main header
Proposed changes
Side effects
Testing
Resolved issues
Fixes: #3060