Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added reserved ipv6 API specs #951

Merged
merged 19 commits into from
Feb 26, 2025
Merged

Added reserved ipv6 API specs #951

merged 19 commits into from
Feb 26, 2025

Conversation

imaskm
Copy link
Contributor

@imaskm imaskm commented Nov 26, 2024

No description provided.

@imaskm imaskm mentioned this pull request Nov 27, 2024
Merged
@loosla loosla mentioned this pull request Nov 28, 2024
Merged
@imaskm imaskm requested a review from loosla November 29, 2024 16:41
@imaskm imaskm requested a review from loosla December 3, 2024 15:12
@imaskm
Copy link
Contributor Author

imaskm commented Jan 24, 2025

@loosla should we replace the [Beta] tagging with "Public Preview" for the public preview release?

@loosla
Copy link
Contributor

loosla commented Jan 24, 2025

@imaskm Definitely. That's a good idea 👍 Feel free to remove 'beta'.

@imaskm imaskm requested a review from loosla January 31, 2025 08:29
@imaskm
Copy link
Contributor Author

imaskm commented Jan 31, 2025 •
edited
Loading

@imaskm Definitely. That's a good idea 👍 Feel free to remove 'beta'.

@loosla I have replaced "Beta" with "Public Preview"

@imaskm
Copy link
Contributor Author

imaskm commented Feb 11, 2025

@imaskm Definitely. That's a good idea 👍 Feel free to remove 'beta'.

@loosla I have replaced "Beta" with "Public Preview"

@loosla can you please take another look in this PR, it was approved before Beta release.

loosla
loosla previously approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@loosla loosla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of suggestions. The rest looks good to me. Many thanks 🚀

@andrewsomething andrewsomething requested review from andrewsomething and removed request for andrewsomething February 26, 2025 15:33
@loosla loosla merged commit 31fb5b2 into digitalocean:main Feb 26, 2025
7 checks passed
@digitalocean-engineering digitalocean-engineering mentioned this pull request Feb 26, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsomething andrewsomething andrewsomething approved these changes

@loosla loosla loosla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@imaskm @loosla @andrewsomething