Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance by not generating newlines in CSS #61

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JoJoDeveloping
Copy link

While investigating why my blog takes so long to build, I found this arcane line breaking mechanism, which is both slow and unnecessary. It can be made faster, see digitalsparky/cssminify#5. However, the best way to improve performance is to simply remove this feature. I don't entirely understand why it was necessary (the library is from 2012, maybe back then people used weird source control software that could not handle that, but git has no such issues), but anyways the files generated here are not added to VCS but instead served over the internet, where it should not matter.

PS: I have not actually tested whether this works, since I don't know Ruby. Please test before merging (or alternatively send me a link or something explaining how I can test this locally).

@digitalsparky
Copy link
Owner

Hi JoJo,

Thanks so much for your support; I'll have a look at this and merge changes with another pull request; it may take a little bit, depending on how my pain is.

Kind Regards,

Matt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants