Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update COMMCARE_ANALYTICS_HOST for staging to point to the staging host #6225

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

SmittieC
Copy link
Contributor

No ticket, I just noticed that the link to the analytics server is broken. We have a staging instance, but staging doesn't point to that. This update should fix this.

Environments Affected

Staging

Announce New Release

No announcement needed, since this is staging

Copy link
Contributor

@mkangia mkangia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code change looks good.
thanks for additional https change.

Do we need to test this to make sure the integration with staging is actually working? I assume there might be other factors to update like some tokens/keys?

@Charl1996
Copy link
Contributor

Do we need to test this to make sure the integration with staging is actually working?

Good idea

I assume there might be other factors to update like some tokens/keys?

No, it's only the link.

@mkangia
Copy link
Contributor

mkangia commented Feb 15, 2024

So we update this via ansible or manually on the server? good to test the integration before merging it.

@SmittieC
Copy link
Contributor Author

So we update this via ansible or manually on the server? good to test the integration before merging it.

The interaction between the staging analytics server (https://commcare-analytics-staging.dimagi.com) and the HQ staging server is already working, so the integration is already tested. This link in the code is the only thing that needs to be updated. It gets its value from the COMMCARE_ANALYTICS_HOST env variable, specified by CC. It's just a link that the user can click on to go to the staging analytics server.

@mkangia
Copy link
Contributor

mkangia commented Feb 15, 2024

Cool. So we would just update the localsettings on staging by running commcare cloud command.

@kaapstorm kaapstorm merged commit d3d74ce into master Mar 13, 2024
2 checks passed
@kaapstorm kaapstorm deleted the cs/update_analytics_endpoint_staging branch March 13, 2024 11:42
@SmittieC
Copy link
Contributor Author

Thanks for merging @kaapstorm. I forgot about this PR 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants