connect channel consent tweaks #1294
Merged
+45
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
SmittieC
reviewed
Mar 10, 2025
| @@ -266,7 +266,8 @@ def _new_user_message(self, message) -> str: | |||
| try: | |||
| self._add_message(message) | |||
| except ParticipantNotAllowedException: | |||
| return self.send_message_to_user("Sorry, you are not allowed to chat to this bot") | |||
| self.send_message_to_user("Sorry, you are not allowed to chat to this bot") | |||
| return "" | |||
SmittieC
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sentry: OPEN-CHAT-STUDIO-NY
Description
Some small tweaks to where consent is checked. The main goal is to check consent earlier in the process and to give feedback in the API views if consent has not been given.
User Impact
Better API feedback. Also using less resources for participants that haven't consented.
Demo
NA
Docs and Changelog
NA