Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A python3 version for pypcd, and it also can load the binary version of PCD #35

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

climbingdaily
Copy link

No description provided.

@SvenMuc
Copy link

SvenMuc commented Aug 11, 2022

I checked your changes. It seems not to work correctly. On Python 2.x it behaves as expected. But in case of writing binary PCD files from a PointCloud2 message on Python 3.8 it still produced corrupted pcd files.

It seems that the binary conversion of the numpy array behaves differently between Python 2 and 3. But I could not identify the root cause yet.

@SvenMuc
Copy link

SvenMuc commented Aug 11, 2022

I found a solution for that. By combining the following two pull request, the issue is solved.

I hope they will be merged some time. Nevertheless, I have a local version which works at least for my use cases.

Regards
Sven

@climbingdaily
Copy link
Author

I found a solution for that. By combining the following two pull request, the issue is solved.

I hope they will be merged some time. Nevertheless, I have a local version which works at least for my use cases.

Regards Sven

Hi Sven, the code works correctly with numpy 1.20.3 environment on my computer. When using it, I just copy the pypcd.py and import it as pypcd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants