Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sqlite): respect case option for foreign keys #1531

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Redlinkk
Copy link

When using the option "quote identifiers", I had errors ("column doesn't exist") when importing foreign keys constraints from sqlite to PG. This should fix the issue

Copy link

@ralgar ralgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm that this works as expected. Solves my issue from #1486.

EDIT: If anyone wants a Docker image built from this PR, you can use ghcr.io/ralgar/pgloader:pr-1531

@hoelter
Copy link

hoelter commented Oct 25, 2024

I can also confirm this works as expected. I was running into the mentioned error when using "with quote identifiers" on a sqlite database, and this change fixed that error with constraints migrating as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants